Greetings and salutations, my fellow VBA-fearin’ congregation. Evangelizin’ Jeff here, spreading the good word about everlastin’ VBA serenity. You may remember me from mah preeeevious sermons such as Tables, PivotTables, and Macros: music to your ears and Big trouble in little spreadsheet. Well today, I’m going to praise the work of a high-yah pow-wah.
Our most pious Brother Jon Peltier (who’s fine presence is to mah left) broke his vow of silence over at the PeltierTech monastery to make a most inspirin’ observation during his recent confession Highlight a Specific Data Label in an Excel Chart:
Because I’ve been doing a lot of coding lately, my first thought was an approach using VBA. Then of course I came to my senses, and worked out a non-programmatic approach.
If possible, it’s usually advantageous not to rely on VBA for such tasks.
Hallelujah, brother!
My visionary brother is right: if there’s one rule of VBA that you should religiously observe, it’s to let the application be the application, where ee-fishin’ tah do so. A whiles back, I jokingly spoke it alike this:
The serenity prayer for Excel:
Lord grant me the VBA skills to automate the things I cannot easily change; the knowledge to leverage fully off the inbuilt features that I can; and the wisdom to know the difference.
(And I particularly chuckled at Excel Ninja BobHC’s response: You been on them tablets again.)
This sentiment is echoed in the commandments given us in Professional Excel Development (written by those latter-day-saints Bovey, Wallentin, Bullen, and Green):
This Good Book evangelizes that Excel developers “…shalt be divided into five different categories”:
- Basic Excel users, whom generally use Excel for fairly simple tasks, but as their exposure to Excel grows, so does the complexity of their worksheets and use of complex worksheet functions, PivotTables, and Charts.
- Power Users, whom have a broad understanding of Excel’s functionality, and occasionally use snippets of VBA from the Net or via the Macro Recorder, but their code tends to be messy, slow, and hard to maintain.
- VBA Developers, whom make extensive use of VBA – perhaps too much…to the point that they tend to use VBA to tackle practically every problem.
- Excel Developers, whom realize that the most efficient and maintainable applications are those that make the most of Excel’s built-in functionality, augmented by VBA where appropriate.
- Professional Excel Developers, whom know more languages than your typical Babel Fish.
That leap from VBA developer to Excel developer is worth striving for. (Don’t bother striving to be a Professional Excel Developer…they are so nerdy that they get about as many dates as your typical cloistered monk or nun). Unfortunately gaining the wisdom to jump from that third class to the forth one ain’t easy, and dedicated sermons on this matter are few and veryfar between.
Far too often the likes of yours truly are often so focused on leading you not into temptation and instead down a righteous path, that we simply never take the flock anywhere near enough to temptation so that we might cautiously peer at it from a safe distance and say in our most solemn and hushed tone “That way surely leads to hellfire, damnation, and eternal recalculation”. No siree, I’m afraid we usually opt instead to simply get the flock away from there.
However, help is at hand, sinners. Forums such as our very own Chandoo.org/forum are a great place to get guidance on such spirited matters…particularly if you ask the right question, such as “What is the best way to achieve X using Excel version Y”. But you’ll need to ask an open question based around what you are trying to accomplish, rather than being overly focused on how you are trying to accomplish it.
For instance, if you ask “How can I efficiently achieve X with VBA“ then that is all you will get…answers about the most efficient way to do it within the confines of the particular tool you have specified. Which will often not be the most efficient way. In fact, I’ve lost count of the number of times where someone has asked for a formula or VBA solution to some devilishly complicated problem – and got something devilishly complicated formula or code as a result – when a mere PivotTable would have sufficed. Or when some very simple Structured Query Language (SQL) via the in-built (but antiquated) Microsoft Query interface would have nailed it.
[Aside: SQL is basically a database language use to perform the database equivalent of lookups and to crunch numbers, or to conditionally join large datasets based on multiple complex conditions. SQL can be directly leveraged by Excel with minimal programming. Heck, you can use SQL to do stuff with NO programming whatsoever via Microsoft Query – a handy (if ancient) little interface bundled into Excel that will look familiar to any Access users. For an excellent Excel-centric introduction to SQL, read Craig Hatmaker’s amazing Beyond Excel: VBA and Database Manipulation blog. Chandoo also has a great guest post by Vijay – Using Excel As Your Database – on this subject. Ignore all the naysayers and unbelievers in the comments who say “Excel shalt not be used a database” for they know not what the point is. Which is that yea Excel doeth speak in SQL tongues at a pinch, and SQL is pure salvation when it comes to manipulating data, be it Big Data, Small Data, or Somewhere-In-Between data.]
Not to mention the miracles even a layperson can perform if they have the almighty Excel 2010 and PowerPivot installed. Or Excel 2013’s Data Model, which lets you mash up data from Excel Tables and serve them up directly as PivotTables with not a VLOOKUP or Macro in sight.
The end of Excel ain’t nigh…
Every release, Excel gets stronger and stronger. Excel 2010 offered us sinners significant improvements over previous versions…giving us things like Slicers and the free PowerPivot add-in. Excel 2013 takes a giant leap forward in allowing us to leverage off of inbuilt functionality to do things that we would otherwise require tons of complex code and complex formulas to achieve. Had Excel 2013 been launched 10 years ago, I simply wouldn’t need to have been a-preaching VBA and SQL to as many unbelievers as I have. If we keep abreast of these changes, then as the functionality of Excel ramps ever up, our code can ramp down accordingly.
The bottom line here is this: if thou strive to be a really good Excel developer then thou best get to know what’s behind just about every nook and cranny of the Excel application itself. Particularly the newly prophesied ones (yea the power of PowerPivot compels you,according to that dark preacher Mike Alexander). So go and explore all those mysterious things on the ribbon. You don’t have to master all of them…but it sure does help if you have an inkling of what they all do. Not just the obvious things like Tables and PivotTables, but the more mysterious ones like Slicers, Data Validation, and What-If-Analyis. And also the completely hidden ones like Goto Special. Not only do all those things do things natively that would require many Shekels of VBA code to replicate, but most are completely addressable from VBA to boot. Meaning an Excel Developer can simply say “Excel – do that thing with this data“.
Before you try to bend Excel to your complete command, study it well. No matter how much you want to jump right in tinker with Excel’s very soul, don’t discount what’s effectively printed on the outside of the box. If you do, you’re just another lazy devil writing hellish code.
Feel free to leave your own theological questions and musings in the confessional box below. Unless it’s to say that you don’t like Pokey LaFarge. Keep that to yourself. Because I love ’em. Saw them live in Wellington a couple of weeks back. Definitely worth checking out if they come to a town near you.
38 Responses to “Time to showoff your VBA skills – Help me fix ActiveSheet.Pictures.Insert snafu”
I tried your code with 2003, it works.
But, I know Addpicture does not take URLs anymore with 2007 onwards, perhaps its the same with picture.insert as well.
http://support.microsoft.com/kb/928983/en-us
The above link gives the solution as "picture fill in a shape such as a rectangle".
Tried to recreate this, but it worked fine for me. I just took the image of the error you showed in the post. Is there more info that can narrow this down a bit?
Don't know if this helps?
http://www.theserverside.com/discussions/thread.tss?thread_id=47101
Hi
Not sure if this is what you're after, but I just tried this
Sub Macro1()
ActiveSheet.Pictures.Insert("http://www.google.co.uk/intl/en_uk/images/logo.gif").Select
End Sub
Tied a button to it on the sheet and it seems to work; hope this helps a little
Ian
@All.. the issue is in Excel 2007. In 2003 ActiveSheet.Pictures.Insert seems to work fine. Unfortunately, I have design this in Excel 2007.. that is why I posted it here..
v2
Sub Macro1()
Set n = ActiveSheet.Pictures.Insert("http://www.google.co.uk/intl/en_uk/images/logo.gif")
With Range("c12")
t = .Top
l = .Left
End With
With n
.Top = t
.Left = l
End With
End Sub
Ian
That didn't come out very well. This positions at c12, so can change easily:
Sub Macro1()
Set n = ActiveSheet.Pictures.Insert("http://www.google.co.uk/intl/en_uk/images/logo.gif")
With Range("c12")
t = .Top
l = .Left
End With
With n
.Top = t
.Left = l
End With
End Sub
Works OK in 2007
Ian
The above codes work fines to my EXCEL 2007. Thanks.
Chandoo:
Try 'ActiveSheet.Pictures.Insert'
With ActiveSheet.Pictures.Insert("C:\Example.png")
.Left = ActiveSheet.Range("A1").Left
.Top = ActiveSheet.Range("A1").Top
End With
activesheet.pictures.insert "C:\Documents and Settings\Jon Peltier\Desktop\2007 stuff\insert_charts_2007.png"
Works for me in 2003 SP3 and in 2007 SP2.
Check the URL, and make sure you have internet connectivity.
What also works, and is newer (pictures.insert was supposedly deprecated in '97):
activesheet.shapes.addpicture "C:\Documents and Settings\Jon Peltier\Desktop\2007 stuff\insert_charts_2007.png", false, true, 200,200,100,100
Unfortunately you must specify dimensions (the last four arguments) and you don't necessarily know them. But the picture size is still related back to the original picture size, so you could use scaleheight and scalewidth to fix this.
Chandoo: I just re-read your post.
The code I posted works for me. However, I'm using a local picture. If you try to add a picture from the web, this won't work.
I remember solving this problem before by adding a rectangle shape first, then using the Shapes.AddPicture method to get a picture from the web.
I'll find that code and post it here.
Some more updates... The code "ActiveSheet.Pictures.Insert (path)" works fine in Excel 2007 at home. Strange it failed miserably on my work laptop. Do you think this has got something to do with SP2 of MS Office 2007 or something like that?
@Ian, Jon: Thanks for the code snippets. I guess I will use my home installation of excel to do this.
Chandoo:
Try this on your work laptop:
Sub test()
ActiveSheet.Shapes.AddShape msoShapeRectangle, 50, 50, 100, 200
ActiveSheet.Shapes(1).Fill.UserPicture _
"http://www.datapigtechnologies.com/images/dpwithPig6.png"
End Sub
FYI:
http://support.microsoft.com/kb/928983/en-us
I didn't mean to post code with a local file, because both approaches worked with an internet image as well. This is in Excel 2007 SP2.
activesheet.pictures.insert "http://peltiertech.com/images/2009-07/col_area_noblanks.png"
Jon: Looks like I have SP1 on my client machine! I wasn't paying attention.
Just checked my home computer where I have SP2, and you're right...looks like they fixed it.
I didn't even bother testing in SP1, though I could if anyone cares enough.
I'm afraid I don't have a solution, but I find it remarkable that after attaining a certain status in the Excel world, Chandoo does not need to post on an Excel discussion forum to get help for an Excel problem. Instead, he posts on his blog and all the gurus come rushing to his help.
Isn't Web 2.0 great?
Teylyn - I saw Chandoo's tweet first, and followed the link back to his blog.
@Mike.. thank you. I have seen the fill rectangle solution before posting the query here. For that matter, I have also tried the solution of embedding a browser control on a spreadsheet. both of these seemed a bit extreme. That is why I have asked it here.
But I guess I will end up using it if I had to build this in work laptop.
@Teylyn: I have thought of posting this in a forum. (Unfortunately I have not been to any excel group in the last 5 years. Last time I was active was when I built a jave based excel sheet construction solution using POI.HSSF classes of Apache... ) After searching for a few hours, I found several forum posts where others had same problem and the solution recommended (using .left and .top parameters) is not working for me. Incidentally most of these solutions are from a certain Jon Peltier 😛
I thought may be the problem is interesting for fellow blog readers. So I posted it here.
Hi,
Adapting the code in the question,
[code]
Sub InsPicture()
pPath = "http://chandoo.org/images/pointy-haired-dilbert-excel-charts-tips.png"
With ActiveSheet.Pictures.Insert(pPath)
.Left = Range("a1").Left
.Top = Range("a1").Top
End With
End Sub
[/code]
Seems to work fine
Looks like it was a problem in 2007 up to SP1, which was corrected in SP2.
@Jon.. seems like the case. I just checked the version at work laptop. it is 12.0.6331.5000 (SP1).
Thank you so much every one. I really appreciate your time and suggestions in solving this.
Glad to help. I couldn't understand why something so straightforward wasn't working.
Hi All
Is there a way of inserting a motion clip eg animated gif or swf or flv?
Thks
You can insert animated GIFs by inserting them in a browser control through VBA. For other types of movies, I can guess you can insert them as clip art.
I WANT THE INSERT PICTURE BY USING COADING
so currently i was struggling same as you, chandoo, with the insert picture method in excel 2007/10 from an url and came along your thread here.
so i re-designed the code on the addshape method as mike was suggesting it and all of the sudden it works just fine.
thanks alot to you guys, you were a great help
a big salut from switzerland
Hi guys,
I need help copying and pasting an image with the path in a cell.
I leave the code.
And thank you very much!
Sub Copiarimg()
Dim pic As Picture
With ActiveSheet
Set pic = .Pictures.Insert(Range("f2").Value)
With .Range("e9:g22")
pic.Top = .Top
pic.Left = .Left
pic.Width = .Width
pic.Height = .Height
End With
End Sub
I've played around with the approaches in these comments, and the code below is what I've come up with. The ImagePath can be a local file or a URL. As Jon mentioned above, the trick is to set an arbitrary value for the width and height, then call the ScaleWidth and ScaleHeight methods afterward to reset the picture to its original size. Once the LockAspectRatio property is set, you can change the picture width and the height will automatically scale (or vice-versa).
Sub AddPictureToRange(TopLeftCellAddress As String, ImagePath As String)
Dim pic As Shape
Dim l As Single, t As Single
Dim temp As Single
l = Me.Range(TopLeftCellAddress).Left
t = Me.Range(TopLeftCellAddress).Top
temp = 10# ' arbitrary value
Set pic = Me.Shapes.AddPicture(ImagePath, msoFalse, msoTrue, l, t, temp, temp)
pic.ScaleHeight 1#, msoTrue
pic.ScaleWidth 1#, msoTrue
pic.LockAspectRatio = msoTrue
End Sub
I need some help with inserting pictures. I have an excel file with a column of item numbers next to this row I want to insert a picture of this item. The pictures are coded with the item number so I tried to insert it with one of the codes above:
Sub InsPicture()
pPath = "http://img.bricklink.com/P/80/55236.gif"
With ActiveSheet.Pictures.Insert(pPath)
End With
End Sub
That worked but I need to do that for every row separtly.
So I tried in the code
pPath = "http://img.bricklink.com/P/80/"&Text(a1;"#")&".gif"
But that gives errors.
Anybody ideas?
Hi Nicholas, I used your solution in a related problem in Excel 2003 and it worked flawlessly..thank you!
Hi Mike Alexander,
Your solution with some changes was helpful in my problem in XL 2007, thanks.
Hi,
thanks all. In addition, I had a problem with multiple pictures inserting (every new picture replaced the prior one). I've changed it a bit, may be helpful..
Sub test()
ActiveSheet.Shapes.AddShape msoShapeRectangle, 50 , 50, 100, 200
ActiveSheet.Shapes(1).Fill.UserPicture _
"http://www.datapigtechnologies.com/images/dpwithPig6.png"
ActiveSheet.Shapes(1).Copy
ActiveSheet.Paste
End Sub
Try this instead:
Sub test()
ActiveSheet.Shapes.AddShape msoShapeRectangle, 50 , 50, 100, 200
ActiveSheet.Shapes(ActiveSheet.Shapes.Count).Fill.UserPicture _
"http://www.datapigtechnologies.com/images/dpwithPig6.png"
End Sub
Thanks to everyone, this thread has been very helpful. However, image inserting still doesn't work quite as expect for me.
While I can get a picture inserted into an Excel 2010 worksheet using either:
1) ActiveSheet.Shapes(ActiveSheet.Shapes.Count).Fill.UserPicture...
2) ActiveSheet.Pictures.Insert(pPath), and
3) Shapes.AddPicture...
unfortunately the images all insert with a display size determined not by the actual pixel dimensions of the image but by the dpi resolution.
So for example, if I insert two copies of the exact same 600x600 pixel image, one with a 300dpi resolution and the other with 72dpi, they display at vastly different sizes on screen.
While this might be intended behaviour for Excel in order to maintain a WSYWIG printing layout, I actually need a way to insert the image based on the the actual pixel dimesnsions and ignoring the dpi resolution.
Any help appreciated.
Thanks
Kez
Not doing an intentional bump, but realised I posted in rely to one of the repsonses here instead of to the main thread, so reposting.
=====
Thanks to everyone, this thread has been very helpful. However, image inserting still doesn’t work quite as expected for me.
While I can get a picture inserted into an Excel 2010 worksheet using any of the below methods:
1) ActiveSheet.Shapes(ActiveSheet.Shapes.Count).Fill.UserPicture....
2) ActiveSheet.Pictures.Insert(pPath), and
3) Shapes.AddPicture....
unfortunately the images all insert with a display size determined not by the actual pixel dimensions of the image but by the dpi resolution.
So for example, if I insert two copies of the exact same 600×600 pixel image, one with a 300dpi resolution and the other with 72dpi, they display at vastly different sizes in Excel on screen.
While this might be intended behaviour for Excel in order to maintain a WYSIWYG printing layout, I actually need a way to insert the images based on the the actual pixel dimesnsions and ignoring the dpi resolution.
Any help appreciated.
Thanks
Kez
Well, answered my own question 🙂
For those who might be interested, you can use this function:
Public Function GetPicDims(strFilePath As String, strFileName As String) As String
GetPicDims = CreateObject("Shell.Application").Namespace((strFilePath)). _
ParseName(strFileName).ExtendedProperty("Dimensions")
End Function
to get the dimensions of the image you want to insert. Then you can parse the return string and use the width and height values to add a rectangle shape of the appropraite size, like:
ActiveSheet.Shapes.AddShape msoShapeRectangle 50, 50, iWidth, iHeight
which you then fill with the picture:
ActiveSheet.Shapes(ActiveSheet.Shapes.Count).Fill.UserPicture "c:\temp\test.jpg"
This way the picture gets inserted using the pixel dimensions and the (print) resolution gets ignored.
If desired, the GetPicDims function can be made more generic to get other ExtendedProperties.
Regards
Kez