This article is part of our VBA Crash Course. Please read the rest of the articles in this series by clicking below links.
- What is VBA & Writing your First VBA Macro in Excel
- Understanding Variables, Conditions & Loops in VBA
- Using Cells, Ranges & Other Objects in your Macros
- Putting it all together – Your First VBA Application using Excel
- My Top 10 Tips for Mastering VBA & Excel Macros
In the part 5 of our VBA Crash Course, let me share you my tips for mastering Excel VBA.
A warning before jumping in to the tips: I am not a VBA expert. I am a learner, just like you. I find VBA quite interesting language to learn and explore. These tips are based on what I have learned writing VBA (and VB code) in the last 12 years.
Tips for using & mastering VBA in short term:
#1 Think Thru before Coding
The best way to solve even a very complex problem is to think thru. Next time, when you are about to automate that report or clean some imported data using VBA, just write the logic down on a paper. See and understand various aspects of the problem. The solution becomes clear to you. It has worked for me and it works for you too.
Related: Building your First VBA Application using Excel
#2 Use the Recorder
Excel’s built in Macro recorder is a great way to learn about new objects and ways to deal with them. I use it all the time to record parts of my code and then customize the output. Just keep in mind that macro recorder does not produce the best or complete code all the time. But it gives you a damn good idea about how to write code for a set of actions.
Related: Introduction to Excel VBA & Writing your First Macro
#3 Use Immediate Window
Excel VBE has a powerful feature called as Immediate window. Think of this like a sandbox. You can write almost any VBA statements here and get quick results. For example, Open VBE (ALT+F11 in Excel) and go to Immediate window.
- Type ?Activecell.Value
- Press Enter
- And you will see the current cell’s value printed in immediate window
Here is a quick demo of immediate window.
#4 Debug.Print is your Friend
There are 3 things you cannot avoid in life
- your 2 year old daughter thinking it would be fun to throw a stone on your car
- your baby boy running and sitting in your lap suddenly making the hot coffee spill on you
- and of course bugs in your code
Bug is a fancy name given to the situation when your code is not doing what it is supposed to do.
But why?!? Well, we don’t know why unless we examine. And this is where Debug.Print can come handy. In below example, you would see the values of all tasks in the immediate window as your program runs.
#5 There is a method for that!
Just like Apple says There is an App for that!, may be Microsoft should say There is a Method for that! about VBA. I say this because VBA comes with a lot of methods and functions to do lots of things. If you are thinking of writing your own code to reverse some text, split something based on a delimiter, find the intersection of 2 ranges or run something after 10 seconds, may be you should before writing your code. Because, my dear, there is a method for that.
Whenever you feel like you are writing code for a problem that is already solved several times, chances are there is some built-in method or object for that. So just search.
Tips for Using & Mastering VBA in Long-term
While the above tips are good for solving your immediate problems, we should always aim for continuous improvement. Here are my top tips for keeping your VBA in shape.
#6 Break Your Work in to Smaller Chunks
No matter how complex your work situation or problem might be, chances are, it is made up of several smaller problems. So break things in to smaller chunks. This coding technique is called as modularization. Modularization has several advantages:
- Reuse: Once you break a big program to smaller parts, you can reuse a smaller part in several places or in other projects.
- Testable: Smaller code fragments are easy to test and debug.
- Maintainable: You can maintain smaller parts easily. You can upgrade them once you get a better version of Excel without breaking much.
#7 Build Iteratively
Rome is not built in one day, so is your buildRome() macro. Whenever you are attempting to automate a whole department’s work, take a step back and see what is the smallest (but most useful) feature you can have. Implement it and then add new features iteratively. That way, your turn-around time is improved, you look pretty in front of your boss and you feel in control of things.
Iterative development also lets you stop whenever you want and you would still have some working piece of code.
#8 Keep a Good Reference Handy
If you are going to use VBA quite often, then invest in a good reference. I suggest John Walkenbach’s Excel 2010 Power Programming if you are looking for one. Good reference books have lots of information and tips buried in them. For example, I keep Excel 2010 Power Programming book on my desk all the time and refer to it whenever I feel like not doing any work. I always learn something new.
#9 Take up Challenges
“Computers are like bicycles for our mind” said Steve Jobs. I am not sure if hours I put on facebook, twitter and gmail are keeping my mind fit. But any time I invest on programming is worth every second. I feel very sharp, excited and stoked when I solve a tricky problem using a computer program (be it VBA, an Excel Formula or php or anything else).
I think if you want to be good in VBA or Excel, then take up challenging work. Try to automate a report that you (or your team) produce using VBA, Try to simplify a formula or improve a chart.
If you are looking for fresh challenges, then look at our forums. We get dozens of interesting questions everyday.
#10 Use VBA only when you need it
Once you start learning VBA, it is natural to feel excited about the possibilities you have. But keep in mind that overusing it can complicate your work.
My suggestion: Use Excel’s native features as much as possible. Excel has several built in features to solve various day to day problems (conditional formatting, pivot tables, formulas, data validation, form controls to name a few). Only when you feel that there is no easy way to use Excel alone to solve a problem, go for VBA.
Example: Recently, I showed you all how to split text on new line using VBA. I did that because I thought there was no way to do it using Excel’s built in text-to-columns utility. Well, I was wrong. As Debra proved in the comments,
Chandoo, if you want to do this in the Text To Columns dialog box,
Select Delimited, then check “Other”
In the box beside Other, press the Alt key, and type (using the number keypad): 0010That should separate the text on the line break character.
So if you feel like there is no way to do something in Excel without resorting to VBA, well, just keep looking, because there might be a way.
What are your Tips for Learning & Mastering VBA?
Its your turn now. What are your top tips for mastering VBA? Please share using comments because I and many of our readers want to learn. Go ahead and post.
Join Our VBA Classes
We run an online VBA (Macros) Class to make you awesome. This class offers 20+ hours of video content on all aspects of VBA – right from basics to advanced stuff. You can watch the lessons anytime and learn at your own pace. Each lesson offers a download workbook with sample code. If you are interested to learn VBA and become a master in it, please consider joining this course.
Click here to learn more and Join our VBA program.
Thanks
This post concludes our series on VBA Crash Course. I hope you enjoyed these 5 articles and learned something new. I really enjoyed writing this series. Thank you so much for your comments and support.
For more about VBA & Macros, consider enrolling in our online course.
38 Responses to “Time to showoff your VBA skills – Help me fix ActiveSheet.Pictures.Insert snafu”
I tried your code with 2003, it works.
But, I know Addpicture does not take URLs anymore with 2007 onwards, perhaps its the same with picture.insert as well.
http://support.microsoft.com/kb/928983/en-us
The above link gives the solution as "picture fill in a shape such as a rectangle".
Tried to recreate this, but it worked fine for me. I just took the image of the error you showed in the post. Is there more info that can narrow this down a bit?
Don't know if this helps?
http://www.theserverside.com/discussions/thread.tss?thread_id=47101
Hi
Not sure if this is what you're after, but I just tried this
Sub Macro1()
ActiveSheet.Pictures.Insert("http://www.google.co.uk/intl/en_uk/images/logo.gif").Select
End Sub
Tied a button to it on the sheet and it seems to work; hope this helps a little
Ian
@All.. the issue is in Excel 2007. In 2003 ActiveSheet.Pictures.Insert seems to work fine. Unfortunately, I have design this in Excel 2007.. that is why I posted it here..
v2
Sub Macro1()
Set n = ActiveSheet.Pictures.Insert("http://www.google.co.uk/intl/en_uk/images/logo.gif")
With Range("c12")
t = .Top
l = .Left
End With
With n
.Top = t
.Left = l
End With
End Sub
Ian
That didn't come out very well. This positions at c12, so can change easily:
Sub Macro1()
Set n = ActiveSheet.Pictures.Insert("http://www.google.co.uk/intl/en_uk/images/logo.gif")
With Range("c12")
t = .Top
l = .Left
End With
With n
.Top = t
.Left = l
End With
End Sub
Works OK in 2007
Ian
The above codes work fines to my EXCEL 2007. Thanks.
Chandoo:
Try 'ActiveSheet.Pictures.Insert'
With ActiveSheet.Pictures.Insert("C:\Example.png")
.Left = ActiveSheet.Range("A1").Left
.Top = ActiveSheet.Range("A1").Top
End With
activesheet.pictures.insert "C:\Documents and Settings\Jon Peltier\Desktop\2007 stuff\insert_charts_2007.png"
Works for me in 2003 SP3 and in 2007 SP2.
Check the URL, and make sure you have internet connectivity.
What also works, and is newer (pictures.insert was supposedly deprecated in '97):
activesheet.shapes.addpicture "C:\Documents and Settings\Jon Peltier\Desktop\2007 stuff\insert_charts_2007.png", false, true, 200,200,100,100
Unfortunately you must specify dimensions (the last four arguments) and you don't necessarily know them. But the picture size is still related back to the original picture size, so you could use scaleheight and scalewidth to fix this.
Chandoo: I just re-read your post.
The code I posted works for me. However, I'm using a local picture. If you try to add a picture from the web, this won't work.
I remember solving this problem before by adding a rectangle shape first, then using the Shapes.AddPicture method to get a picture from the web.
I'll find that code and post it here.
Some more updates... The code "ActiveSheet.Pictures.Insert (path)" works fine in Excel 2007 at home. Strange it failed miserably on my work laptop. Do you think this has got something to do with SP2 of MS Office 2007 or something like that?
@Ian, Jon: Thanks for the code snippets. I guess I will use my home installation of excel to do this.
Chandoo:
Try this on your work laptop:
Sub test()
ActiveSheet.Shapes.AddShape msoShapeRectangle, 50, 50, 100, 200
ActiveSheet.Shapes(1).Fill.UserPicture _
"http://www.datapigtechnologies.com/images/dpwithPig6.png"
End Sub
FYI:
http://support.microsoft.com/kb/928983/en-us
I didn't mean to post code with a local file, because both approaches worked with an internet image as well. This is in Excel 2007 SP2.
activesheet.pictures.insert "http://peltiertech.com/images/2009-07/col_area_noblanks.png"
Jon: Looks like I have SP1 on my client machine! I wasn't paying attention.
Just checked my home computer where I have SP2, and you're right...looks like they fixed it.
I didn't even bother testing in SP1, though I could if anyone cares enough.
I'm afraid I don't have a solution, but I find it remarkable that after attaining a certain status in the Excel world, Chandoo does not need to post on an Excel discussion forum to get help for an Excel problem. Instead, he posts on his blog and all the gurus come rushing to his help.
Isn't Web 2.0 great?
Teylyn - I saw Chandoo's tweet first, and followed the link back to his blog.
@Mike.. thank you. I have seen the fill rectangle solution before posting the query here. For that matter, I have also tried the solution of embedding a browser control on a spreadsheet. both of these seemed a bit extreme. That is why I have asked it here.
But I guess I will end up using it if I had to build this in work laptop.
@Teylyn: I have thought of posting this in a forum. (Unfortunately I have not been to any excel group in the last 5 years. Last time I was active was when I built a jave based excel sheet construction solution using POI.HSSF classes of Apache... ) After searching for a few hours, I found several forum posts where others had same problem and the solution recommended (using .left and .top parameters) is not working for me. Incidentally most of these solutions are from a certain Jon Peltier 😛
I thought may be the problem is interesting for fellow blog readers. So I posted it here.
Hi,
Adapting the code in the question,
[code]
Sub InsPicture()
pPath = "http://chandoo.org/images/pointy-haired-dilbert-excel-charts-tips.png"
With ActiveSheet.Pictures.Insert(pPath)
.Left = Range("a1").Left
.Top = Range("a1").Top
End With
End Sub
[/code]
Seems to work fine
Looks like it was a problem in 2007 up to SP1, which was corrected in SP2.
@Jon.. seems like the case. I just checked the version at work laptop. it is 12.0.6331.5000 (SP1).
Thank you so much every one. I really appreciate your time and suggestions in solving this.
Glad to help. I couldn't understand why something so straightforward wasn't working.
Hi All
Is there a way of inserting a motion clip eg animated gif or swf or flv?
Thks
You can insert animated GIFs by inserting them in a browser control through VBA. For other types of movies, I can guess you can insert them as clip art.
I WANT THE INSERT PICTURE BY USING COADING
so currently i was struggling same as you, chandoo, with the insert picture method in excel 2007/10 from an url and came along your thread here.
so i re-designed the code on the addshape method as mike was suggesting it and all of the sudden it works just fine.
thanks alot to you guys, you were a great help
a big salut from switzerland
Hi guys,
I need help copying and pasting an image with the path in a cell.
I leave the code.
And thank you very much!
Sub Copiarimg()
Dim pic As Picture
With ActiveSheet
Set pic = .Pictures.Insert(Range("f2").Value)
With .Range("e9:g22")
pic.Top = .Top
pic.Left = .Left
pic.Width = .Width
pic.Height = .Height
End With
End Sub
I've played around with the approaches in these comments, and the code below is what I've come up with. The ImagePath can be a local file or a URL. As Jon mentioned above, the trick is to set an arbitrary value for the width and height, then call the ScaleWidth and ScaleHeight methods afterward to reset the picture to its original size. Once the LockAspectRatio property is set, you can change the picture width and the height will automatically scale (or vice-versa).
Sub AddPictureToRange(TopLeftCellAddress As String, ImagePath As String)
Dim pic As Shape
Dim l As Single, t As Single
Dim temp As Single
l = Me.Range(TopLeftCellAddress).Left
t = Me.Range(TopLeftCellAddress).Top
temp = 10# ' arbitrary value
Set pic = Me.Shapes.AddPicture(ImagePath, msoFalse, msoTrue, l, t, temp, temp)
pic.ScaleHeight 1#, msoTrue
pic.ScaleWidth 1#, msoTrue
pic.LockAspectRatio = msoTrue
End Sub
I need some help with inserting pictures. I have an excel file with a column of item numbers next to this row I want to insert a picture of this item. The pictures are coded with the item number so I tried to insert it with one of the codes above:
Sub InsPicture()
pPath = "http://img.bricklink.com/P/80/55236.gif"
With ActiveSheet.Pictures.Insert(pPath)
End With
End Sub
That worked but I need to do that for every row separtly.
So I tried in the code
pPath = "http://img.bricklink.com/P/80/"&Text(a1;"#")&".gif"
But that gives errors.
Anybody ideas?
Hi Nicholas, I used your solution in a related problem in Excel 2003 and it worked flawlessly..thank you!
Hi Mike Alexander,
Your solution with some changes was helpful in my problem in XL 2007, thanks.
Hi,
thanks all. In addition, I had a problem with multiple pictures inserting (every new picture replaced the prior one). I've changed it a bit, may be helpful..
Sub test()
ActiveSheet.Shapes.AddShape msoShapeRectangle, 50 , 50, 100, 200
ActiveSheet.Shapes(1).Fill.UserPicture _
"http://www.datapigtechnologies.com/images/dpwithPig6.png"
ActiveSheet.Shapes(1).Copy
ActiveSheet.Paste
End Sub
Try this instead:
Sub test()
ActiveSheet.Shapes.AddShape msoShapeRectangle, 50 , 50, 100, 200
ActiveSheet.Shapes(ActiveSheet.Shapes.Count).Fill.UserPicture _
"http://www.datapigtechnologies.com/images/dpwithPig6.png"
End Sub
Thanks to everyone, this thread has been very helpful. However, image inserting still doesn't work quite as expect for me.
While I can get a picture inserted into an Excel 2010 worksheet using either:
1) ActiveSheet.Shapes(ActiveSheet.Shapes.Count).Fill.UserPicture...
2) ActiveSheet.Pictures.Insert(pPath), and
3) Shapes.AddPicture...
unfortunately the images all insert with a display size determined not by the actual pixel dimensions of the image but by the dpi resolution.
So for example, if I insert two copies of the exact same 600x600 pixel image, one with a 300dpi resolution and the other with 72dpi, they display at vastly different sizes on screen.
While this might be intended behaviour for Excel in order to maintain a WSYWIG printing layout, I actually need a way to insert the image based on the the actual pixel dimesnsions and ignoring the dpi resolution.
Any help appreciated.
Thanks
Kez
Not doing an intentional bump, but realised I posted in rely to one of the repsonses here instead of to the main thread, so reposting.
=====
Thanks to everyone, this thread has been very helpful. However, image inserting still doesn’t work quite as expected for me.
While I can get a picture inserted into an Excel 2010 worksheet using any of the below methods:
1) ActiveSheet.Shapes(ActiveSheet.Shapes.Count).Fill.UserPicture....
2) ActiveSheet.Pictures.Insert(pPath), and
3) Shapes.AddPicture....
unfortunately the images all insert with a display size determined not by the actual pixel dimensions of the image but by the dpi resolution.
So for example, if I insert two copies of the exact same 600×600 pixel image, one with a 300dpi resolution and the other with 72dpi, they display at vastly different sizes in Excel on screen.
While this might be intended behaviour for Excel in order to maintain a WYSIWYG printing layout, I actually need a way to insert the images based on the the actual pixel dimesnsions and ignoring the dpi resolution.
Any help appreciated.
Thanks
Kez
Well, answered my own question 🙂
For those who might be interested, you can use this function:
Public Function GetPicDims(strFilePath As String, strFileName As String) As String
GetPicDims = CreateObject("Shell.Application").Namespace((strFilePath)). _
ParseName(strFileName).ExtendedProperty("Dimensions")
End Function
to get the dimensions of the image you want to insert. Then you can parse the return string and use the width and height values to add a rectangle shape of the appropraite size, like:
ActiveSheet.Shapes.AddShape msoShapeRectangle 50, 50, iWidth, iHeight
which you then fill with the picture:
ActiveSheet.Shapes(ActiveSheet.Shapes.Count).Fill.UserPicture "c:\temp\test.jpg"
This way the picture gets inserted using the pixel dimensions and the (print) resolution gets ignored.
If desired, the GetPicDims function can be made more generic to get other ExtendedProperties.
Regards
Kez