VBA Userform Save or Not Save on Exit

[Yodelayheewho]

When executing the following code and selecting "Yes" it works as intended it saves the userform and displays the confirmation message. However, when selecting "No" it unloads the form without displaying the message.

'Exit Form Button'
Private Sub FormExit_Click()
Dim MsgBoxResult As Long
MsgBoxResult = MsgBox("Save Changes?", vbYesNo)
    If MsgBoxResult = vbYes Then
        ActiveWorkbook.Save
        MsgBox ("Your work is saved. Have a great day!")
     ElseIf MsgBoxResults = vbNo Then
        MsgBox ("Your work was NOT saved. See ya!")
    End If
Unload MasterForm
End Sub

Thank you in advance for your consideration!

 

[vletm]

Yodelayheewho

MsgBox function (Visual Basic for Applications)

Office VBA reference topic

learn.microsoft.com

Displays a message in a dialog box, waits for the user to click a button, and returns an Integer indicating which button the user clicked.

VBA If, ElseIf, Else (Ultimate Guide to If Statements) - Automate Excel

In this ArticleVBA If StatementIf ThenElseIF – Multiple ConditionsElseIf-ElseNested IFsIF – Or, And, Xor, NotIf OrIf AndIf XorIf NotIf ComparisonsIf – Boolean FunctionComparing TextVBA If LikeIf LoopsIf Else ExamplesCheck if Cell is EmptyCheck if Cell Contains Specific TextCheck if cell contains...

www.automateexcel.com

I would use if ... then ... else ... endif - syntax.

Private Sub FormExit_Click()
    Dim MsgBoxResult As Integer
    Dim txt As String
    If MsgBox("Save Changes?", vbYesNo) = vbYes Then
        ActiveWorkbook.Save
        txt = "Your work is saved. Have a great day!"
     Else
        txt = "Your work was NOT saved. See ya!"
    End If
    MsgBox txt
    Unload MasterForm
End Sub

 

[Yodelayheewho]

Perfection! Thank you so very much vletm!
One question. You have Dim MsgBox Result As Integer. The result is not a number it is text. How does this work?

 

[vletm]

Yodelayheewho
Seems that I skipped to delete that Dim MsgBoxResult As Integer -line.
Your above writing has anyway error ... MsgBox Result.
Did You check that my the 1st link? ... please, recheck that.
... then You'll notice that MsgBox gives integer - You can verify that Yourself too while running that code.
Instead numbers, there can use vbYes,vbNo and many others.

 

[Yodelayheewho]

I did read the articles and saved them for future reference. I learned some new things today.
Here is the updated code and it works great. Thanks again vletm!

'Exit Form Button'
Private Sub FormExit_Click()
Dim txt As String
If MsgBox("Save Changes?", vbYesNo) = vbYes Then
        ActiveWorkbook.Save
        txt = "Your work is saved. Have a great day!"
     Else
        txt = "Your work was NOT saved. See ya!"
    End If
    MsgBox txt
Unload MasterForm
End Sub