PDF Export

[paulcherianc]

Dear Experts!

Can you please let me know where am I wrong with my coding? I am not able to run this macro. I think it happened when I inserted InvNo in between the codes.

 Option Explicit
Public Sub PDFexport1()
Dim PdfPath As String
Dim InvNo As String

InvNo = Worksheets("01Q").Range("E17").Value


ThisWorkbook.Sheets(Array("01Q", "Alstom IT Clinic QAR", "IT")).Select

ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
    Worksheets("Macro").Range("L13") & "\" & "Alstom Invoices" & InvNo & ".pdf", Quality:=xlQualityStandard, IncludeDocProperties:=True, _
     IgnorePrintAreas:=False, OpenAfterPublish:=False

PdfPath = Worksheets("Macro").Range("L13") & "\" & "Alstom Invoices" & InvNo & ".pdf"

Worksheets("SummaryTemp").Range("A1").Value = PdfPath

End Sub

 

[p45cal]

Instead of using the likes of:
Worksheets("Macro").Range("L13") & "\" & "Alstom Invoices" & InvNo & ".pdf"
twice, use it once. It saves editing in two places and is a bit more robust:

Public Sub PDFexport1()
Dim PdfPath As String
Dim InvNo As String

InvNo = Worksheets("01Q").Range("E17").Value
ThisWorkbook.Sheets(Array("01Q", "Alstom IT Clinic QAR", "IT")).Select
PdfPath = Worksheets("Macro").Range("L13") & "\" & "Alstom Invoices" & InvNo & ".pdf"
ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:=PdfPath, Quality:=xlQualityStandard, IncludeDocProperties:=True, IgnorePrintAreas:=False, OpenAfterPublish:=False
Worksheets("SummaryTemp").Range("A1").Value = PdfPath
End Sub

To come to the question, what error are you getting, and what line is highlighted when you click the Debug button?
It could be worth checking what ends up in the variable InvNo to check that you're not trying to generate an illegal file name.

 

[paulcherianc]

Its fine now. Macro was picking a date and as it won't allow the characters "*","/" as file name I changed the date format on the coding and fixed it.Thanks!