Button Macro Only Works if Run in Visual Basic View

[Yodelayheewho]

I'm running into a couple of issues with a macro. I'm VERY new to VBA. I've attached a sample of what I'm building. I'm still in the early stages.
First issue: I have to manually run the macro for a photo I selected to appear
1. Open file to see System Sales Order Manager > Project Status
2. Click on Add Picture
3. Select Photo
4. ISSUE: Photo does not change
5. Open Visual Basic > Modules > PicMacro and open macro > click run
6. The picture changes
What is missing in the code or my set up that prevents the macro from displaying the photo I selected?

Second issue: The photo is supposed to only show in J10. However, if you click on the tabs, i.e., TASKS, CUSTOMER, PROPOSAL, etc. the photo shows up on J25, J45, J65, etc.
Thank you in advance for your time and willingness to assist me!

 

[rollis13]

You forgot to 'show' the picture after adding it. Add this line to your macro Add_Pic:

'...'
    End With
        'On Existing Records, Add/Update Pictures in Database
        Call Show_Pic                             '<- added
NoSelection:
    End With
End Sub

Didn't check for other issues, I'll leave it to you.

 

[Yodelayheewho]

YOU ARE AWESOME!!!! Thank you so very, very much!

I'm going to continue to work on figuring out the second issue. Again, thank you!!!

 

[rollis13]

Just a little help before going to sleep, it's late for me .
Add this to your macro SwitchHorizontalTabs:

'...'
With Sheet1
        SelCol = .Range("B2").Value
        '---added---
        If SelCol = 5 Then
            .Shapes("Pic").Visible = msoTrue
        Else
            .Shapes("Pic").Visible = msoFalse
        End If
        '-----------
        .Range("5:144").EntireRow.Hidden = True
        FirstRow = 5 + ((SelCol - 5) * 20)
        .Range(FirstRow & ":" & FirstRow + 19).EntireRow.Hidden = False
    End With
End Sub

 

[Yodelayheewho]

It works perfectly! Did you take courses in VBA/Macros or did you learn on your own? I'm such an Excel geek, but have so much more to learn. Thank you very much!

 

[rollis13]

This and that and banging my head and it has taken me at least 40 years .
Thanks for the positive feedback, glad having been of some help.

 

[Yodelayheewho]

Yeah, I'm banging my head too, but I also love figuring this out. Excel does some cool things. Thanks again!

 

[Marc L]

Learning Excel VBA

Hello Everyone, Actually, I just want to ask you all perfect & extra ordinary talented people here in excel VBA that, what is easiest and an early way for learning the excel VBA. How much daily practice is required & what should be material, I should read & learn. If someone can guide me...

chandoo.org